Skip to content

[release-1.2] ESO-566: Allow overriding operand container args outside the ExternalSecretsConfig API - #176

Open
bharath-b-rh wants to merge 3 commits into
openshift:release-1.2from
bharath-b-rh:release-1.2
Open

[release-1.2] ESO-566: Allow overriding operand container args outside the ExternalSecretsConfig API#176
bharath-b-rh wants to merge 3 commits into
openshift:release-1.2from
bharath-b-rh:release-1.2

Conversation

@bharath-b-rh

@bharath-b-rh bharath-b-rh commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Manual cherrypick of #174: allow override of operand Deployment container args as comma-separated --key=value flags (OPERAND_EXTERNAL_SECRETS_ARGS, OPERAND_WEBHOOK_ARGS, OPERAND_CERT_CONTROLLER_ARGS, OPERAND_BITWARDEN_SDK_SERVER_ARGS) via operator Subscription CR.

Invalid overrides mark ExternalSecretsConfig Degraded; correcting or clearing the env recovers Ready / default args.

Commits

  1. Feature cherry-pick (controller + unit/e2e coverage)
  2. E2E OLM helpers use the dynamic client instead of vendoring github.com/operator-framework/api
  3. Bump golang.org/x/text to v0.39.0 for GO-2026-5970 / CVE-2026-56852

Differences from main

Area main release-1.2
Feature / error type UserConfigurationError Same (clean cherry-pick)
OLM Subscription helpers Typed operator-framework/api + scheme Dynamic/unstructured (no new OLM dep)
Lifecycle TODOs Remove in v1.4.0 / advancedOverrides migration Omitted — hatch remains for the 1.2 stream

Test plan

  • Unit: go test ./pkg/controller/external_secrets/ -count=1 -run 'TestParseOperandArgsEnv|TestMergeContainerArgs|TestApplyOperandArgsFromEnv'
  • Deploy a 1.2 operator image that includes this change
  • E2E: make test-e2e E2E_GINKGO_LABEL_FILTER="Feature:OverrideOperandArgs"
  • Confirm invalid args → Degraded; correction → Ready; unset → default args restored
  • Confirm golang.org/x/text is at v0.39.0 (GO-2026-5970)

@bharath-b-rh
ESO-566: Allow overriding operand container args outside the External…
f282e7c 
…SecretsConfig API

Signed-off-by: Bharath B <bhb@redhat.com>
@bharath-b-rh
ESO-566: Use dynamic client for e2e OLM helpers instead of operator-f…
c6b3fd9 
…ramework/api

Signed-off-by: Bharath B <bhb@redhat.com>
@openshift-ci-robot

openshift-ci-robot commented Aug 8, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@bharath-b-rh: This pull request references ESO-566 which is a valid jira issue.

Details

In response to this:

Summary

Manual cherrypick of #174: allow override of operand Deployment container args as comma-separated --key=value flags (OPERAND_EXTERNAL_SECRETS_ARGS, OPERAND_WEBHOOK_ARGS, OPERAND_CERT_CONTROLLER_ARGS, OPERAND_BITWARDEN_SDK_SERVER_ARGS) via operator Subscription CR.

Invalid overrides mark ExternalSecretsConfig Degraded; correcting or clearing the env recovers Ready / default args.

Commits

  1. Feature cherry-pick (controller + unit/e2e coverage)
  2. E2E OLM helpers use the dynamic client instead of vendoring github.com/operator-framework/api
  3. Bump golang.org/x/text to v0.39.0 for GO-2026-5970 / CVE-2026-56852

Differences from main

Area main release-1.2
Feature / error type UserConfigurationError Same (clean cherry-pick)
OLM Subscription helpers Typed operator-framework/api + scheme Dynamic/unstructured (no new OLM dep)
Lifecycle TODOs Remove in v1.4.0 / advancedOverrides migration Omitted — hatch remains for the 1.2 stream

Test plan

  • Unit: go test ./pkg/controller/external_secrets/ -count=1 -run 'TestParseOperandArgsEnv|TestMergeContainerArgs|TestApplyOperandArgsFromEnv'
  • Deploy a 1.2 operator image that includes this change
  • E2E: make test-e2e E2E_GINKGO_LABEL_FILTER="Feature:OverrideOperandArgs"
  • Confirm invalid args → Degraded; correction → Ready; unset → default args restored
  • Confirm golang.org/x/text is at v0.39.0 (GO-2026-5970)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 8, 2026
@coderabbitai

coderabbitai Bot commented Aug 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 538149b7-9e7c-4ca5-9a82-7d08537e0125

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from TrilokGeer and mytreya-rh August 8, 2026 08:14
@openshift-ci

openshift-ci Bot commented Aug 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2026
@bharath-b-rh bharath-b-rh changed the title ESO-566: Allow overriding operand container args outside the ExternalSecretsConfig API [release-1.2] ESO-566: Allow overriding operand container args outside the ExternalSecretsConfig API Aug 8, 2026
@bharath-b-rh
Bump golang.org/x/text to v0.39.0 to address GO-2026-5970
bcf950a 
Signed-off-by: Bharath B <bhb@redhat.com>
@bharath-b-rh

bharath-b-rh commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

/test images

@openshift-ci

openshift-ci Bot commented Aug 8, 2026

Copy link
Copy Markdown

@bharath-b-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mytreya-rh mytreya-rh Awaiting requested review from mytreya-rh
@TrilokGeer TrilokGeer Awaiting requested review from TrilokGeer

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bharath-b-rh @openshift-ci-robot